Move confirmation prompt to a static function #21006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21006-20c8d32 | |
| Version | 22.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 20c8d32 | |
| App Center Build | jetpack-installable-builds #5231 |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21006-20c8d32 | |
| Version | 22.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 20c8d32 | |
| App Center Build | WPiOS - One-Offs #6205 |
mokagio
reviewed
Jul 7, 2023
Comment on lines
+185
to
+187
| // Bind the subscription with the lifetime of the alert. When the alert instance is released, `cancellable` will be | ||
| // released too which will automatically unregister the notification observer. | ||
| objc_setAssociatedObject(alertController, &UIAlertController.cancellableKey, cancellable, .OBJC_ASSOCIATION_RETAIN_NONATOMIC) |
There was a problem hiding this comment.
@crazytonyli @jkmassel I generally prefer having an extension on UIAlertController that encapsulates all the configuration logic for a customize instance.
However, in this particular instance, the approach comes with the need for this legit but unusual objc_setAssociatedObject call.
All in all, I think the original version from #21003 might be best because of it's straightforwardness.
I'll leave it up to @jkmassel to decide. Also, I think given this address an relatively unfrequent use case (changing the user name) we don't need to rush into merging either version. Or, if we really want to rest assured that the bug is fixed ASAP, we could merge either for 22.8, and then refine if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #21003 and a follow up of #21003 (comment).
Relates to #20994.
When the user wants to change their username from
ChangeUsernameViewController, the app shows a confirmation alert which has a text field to ask the user to type the new username. The confirmation button in the alert will be disabled first and turn into enabled only when the user types the new username correctly.Current implementation adds notification observer at the time of creating the alert and unregisters the observer when alert is dismissed. There are a few issues with current implementation, I'll post an inline comments to highlight them. This PR refactors the observing notification approach to register an observer once the view controller is loaded and let iOS SDK to unregister it when the view controller is released.
Test Instructions
editableUsername, so that we can enter the "change username" screen.The "Change username" alert button should be disabled. The button should become enabled when the text in the text field matches the new username, and should become disable if it doesn't.
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
What's described in the test instruction section.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A